Discussion:
[GIT]: Networking
(too old to reply)
David Miller
2009-12-06 03:35:05 UTC
Permalink
Ingo Molnar
2009-12-08 19:45:30 UTC
Permalink
hi Dave,

i just switched to today's -git tree and there's this new build failure
on x86:

net/sctp/sysctl.c:251: error: unknown field 'strategy' specified in initializer
net/sctp/sysctl.c:251: error: 'sysctl_intvec' undeclared here (not in a function)

havent looked into it yet - config attached.

Ingo
Ingo Molnar
2009-12-08 19:52:09 UTC
Permalink
Post by Ingo Molnar
hi Dave,
i just switched to today's -git tree and there's this new build failure
net/sctp/sysctl.c:251: error: unknown field 'strategy' specified in initializer
net/sctp/sysctl.c:251: error: 'sysctl_intvec' undeclared here (not in a function)
havent looked into it yet - config attached.
That's interaction with the strategy handler removal from Eric. I think
the patch below will do the trick - the callsites have been updated
already to use proc_handler, so ->handler was a dead field.

Ingo

Signed-off-by: Ingo Molnar <***@elte.hu>

diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
index 419e1e9..832590b 100644
--- a/net/sctp/sysctl.c
+++ b/net/sctp/sysctl.c
@@ -248,7 +248,6 @@ static ctl_table sctp_table[] = {
.maxlen = sizeof(int),
.mode = 0644,
.proc_handler = &proc_dointvec_minmax,
- .strategy = &sysctl_intvec,
.extra1 = &one,
.extra2 = &rwnd_scale_max,
},
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller
2009-12-08 20:50:32 UTC
Permalink
From: Ingo Molnar <***@elte.hu>
Date: Tue, 8 Dec 2009 20:45:30 +0100
Post by Ingo Molnar
i just switched to today's -git tree and there's this new build failure
net/sctp/sysctl.c:251: error: unknown field 'strategy' specified in initializer
net/sctp/sysctl.c:251: error: 'sysctl_intvec' undeclared here (not in a function)
havent looked into it yet - config attached.
It's probably a conflict with Eric Beiderman's sysctl cleanups that
got merged in at the same time.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Eric W. Biederman
2009-12-09 01:54:47 UTC
Permalink
Post by David Miller
Date: Tue, 8 Dec 2009 20:45:30 +0100
Post by Ingo Molnar
i just switched to today's -git tree and there's this new build failure
net/sctp/sysctl.c:251: error: unknown field 'strategy' specified in initializer
net/sctp/sysctl.c:251: error: 'sysctl_intvec' undeclared here (not in a function)
havent looked into it yet - config attached.
It's probably a conflict with Eric Beiderman's sysctl cleanups that
got merged in at the same time.
Yep. You guys figured it out. Thanks all.

I have looked and I don't see any more .ctl_name or .strategy fields
left in the kernel so this should be the last of it.

Hooray! Maintenance of binary sysctl is gone!

Eric
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Linus Torvalds
2009-12-08 20:51:00 UTC
Permalink
Post by Ingo Molnar
hi Dave,
i just switched to today's -git tree and there's this new build failure
net/sctp/sysctl.c:251: error: unknown field 'strategy' specified in initializer
net/sctp/sysctl.c:251: error: 'sysctl_intvec' undeclared here (not in a function)
havent looked into it yet - config attached.
That's my mismerge. I should have removed the strategy field too, not just
the ctr_name. My bad, will fix up,

Linus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller
2009-12-08 20:52:11 UTC
Permalink
From: Linus Torvalds <***@linux-foundation.org>
Date: Tue, 8 Dec 2009 12:51:00 -0800 (PST)
Post by Linus Torvalds
That's my mismerge. I should have removed the strategy field too, not just
the ctr_name. My bad, will fix up,
Thanks everyone for working to fix this up.
David Miller
2009-12-12 02:17:12 UTC
Permalink
Pretty much entirely bug fixes including a 2.6.32 regression fix for
stalled TCP regressions (will be sent to -stable) from Damian
Lukowski.

Resolve some wireless merge issues.

As well as a fix for NETREG_UNINITIALIZED state net devices,
from Krishna Kumar.

There is an 'origin' pull in here to resolve a net/tcp.h conflict with
your tree.

Please pull, thanks a lot!

The following changes since commit 2fe77b81c77eed92c4c0439f74c8148a295b4a86:
Linus Torvalds (1):
Merge branch 'next' of git://git.kernel.org/.../davej/cpufreq

are available in the git repository at:

master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git master

Amit Kumar Salecha (2):
netxen: protect device reset by rtnl_lock
netxen:fix napi intr enable check

Andrew Morton (1):
net/rfkill/core.c: work around gcc-4.0.2 silliness

Anton Vorontsov (1):
gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y

Asier Llano (1):
net/mpc5200: Fix locking on fec_mpc52xx driver

Barry Song (1):
can: add the driver for Analog Devices Blackfin on-chip CAN controllers

Breno Leitao (1):
cxgb3: Fixing EEH handlers

Brice Goglin (1):
myri10ge: use src+dst for rss hashing

Bruce Allan (3):
e1000e: minor correction to name of bit in CTRL_EXT register
e1000e: replace incorrect use of GG82563_REG macro
e1000e: only perform ESB2 MDIC workaround on certain configurations

Damian Lukowski (2):
tcp: Stalling connections: Fix timeout calculation routine
tcp: Stalling connections: Move timeout calculation routine

David Kilroy (1):
orinoco: remove spare KERN_DEBUG

David S. Miller (4):
Merge branch 'master' of git://git.kernel.org/.../linville/wireless-next-2.6
tcp: Remove runtime check that can never be true.
Merge branch 'master' of git://git.kernel.org/.../linville/wireless-2.6
Merge branch 'master' of /home/davem/src/GIT/linux-2.6/

Denis Kirjanov (1):
mv643xx_eth: check for valid hw address (resubmit)

Dhananjay Phadke (1):
netxen: fix firmware type check

Don Skidmore (1):
ixgbe: add support for 82599 KR device 0x1517

Eric Dumazet (4):
ixgbe: Fix TX stats accounting
tcp: Fix a connect() race with timewait sockets
tcp: Fix a connect() race with timewait sockets
tcp: documents timewait refcnt tricks

Felix Fietkau (1):
ath9k: fix tx status reporting

Heiko Carstens (2):
net: fix compat_sys_recvmmsg parameter type
net: use compat helper functions in compat_sys_recvmmsg

Herton Ronaldo Krzesinski (1):
rtl8187: add radio led and fix warnings on suspend

Ilpo Järvinen (1):
tcp: fix retrans_stamp advancing in error cases

Javier Cardona (2):
mac80211: Fixed bug in mesh portal paths
mac80211: Revert 'Use correct sign for mesh active path refresh'

Jie Yang (2):
atl1c:add pci map direction in atl1c_buffer flags
atl1c:use common_task instead of reset_task and link_chg_task

Joe Perches (1):
include/linux/if_ether.h: Remove unused defines MAC_BUF_SIZE and DECLARE_MAC_BUF

Johannes Berg (1):
mac80211: recalculate idle later in MLME

John W. Linville (3):
iwlwifi: fix warning from ieee80211_stop_tx_ba_cb_irqsafe argument change
wireless: correctly report signal value for IEEE80211_HW_SIGNAL_UNSPEC
wireless: update old static regulatory domain rules

Julia Lawall (1):
net/mac80211: Correct size given to memset

Kalle Valo (3):
wl1251: remove false warning messages
wl1251: fix bssid handling
wl1251: don't build null data template in wl1251_op_config()

Krishna Kumar (1):
net: Handle NETREG_UNINITIALIZED devices correctly

Larry Finger (2):
rtl8187: Fix wrong rfkill switch mask for some models
b43: Remove reset after fatal DMA error

Lennert Buytenhek (12):
mwl8k: fix MCS bitmap size in SET_RATE command
mwl8k: fix UPDATE_STADB command struct legacy_rates array length
mwl8k: prevent corruption of QoS field on receive
mwl8k: fix addr4 zeroing and payload overwrite on DMA header creation
mwl8k: properly report rate on received 40MHz packets
mwl8k: allow more time for firmware commands to complete
mwl8k: allow more time for transmit rings to drain
mwl8k: increase firmware loading timeouts
mwl8k: don't forget to call pci_disable_device()
mwl8k: struct ieee80211_rx_status::qual is deprecated
mwl8k: don't overwrite mwl8k_vif::bssid until after disassociation
mwl8k: don't complain about oversized beacons in FINALIZE_JOIN

Luis R. Rodriguez (1):
ath5k: enable EEPROM checksum check

Martin Willi (1):
xfrm: Fix truncation length of authentication algorithms installed via PF_KEY

Michael Chan (2):
cnic: Send delete command when shutting down iSCSI ring.
cnic: Zero out status block and Event Queue indices.

Mike Frysinger (1):
smc91x: fix unused flags warnings on UP systems

Oliver Neukum (1):
MAINTAINERS: Transfering maintainership of cdc-ether

Paul Mundt (1):
net: smc91x: Fix up type mismatch in smc_drv_resume().

Randy Dunlap (1):
net: niu uses crc32, so select CRC32

Shahar Or (1):
ath5k: add support for Dell Vostro A860 LED

Stanislav Brabec (1):
b44 WOL setup: one-bit-off stack corruption kernel panic fix

Takashi Iwai (2):
net: Fix Yukon-2 Optima TCP offload setup
net: Add missing TST_CFG_WRITE bits around sky2_pci_write

Tilman Schmidt (2):
gigaset: don't enable any debugging output by default
gigaset: documentation amendments

Vasanthakumar Thiagarajan (1):
mac80211: Fix bug in computing crc over dynamic IEs in beacon

Vivek Natarajan (2):
mac80211: Fix dynamic power save for scanning.
cfg80211: Clear encryption privacy when key off is done.

chas williams - CONTRACTOR (3):
atm: [lec] initialize .netdev_ops before calling register_netdev()
atm: [he] adjust tests to account for sk_wmem_alloc changes
atm: [br2684] allow routed mode operation again

Documentation/isdn/README.gigaset | 116 +++-
MAINTAINERS | 3 +-
drivers/atm/he.c | 4 +-
drivers/isdn/gigaset/common.c | 2 +-
drivers/net/Kconfig | 1 +
drivers/net/atl1c/atl1c.h | 17 +-
drivers/net/atl1c/atl1c_main.c | 94 ++--
drivers/net/b44.c | 3 +-
drivers/net/can/Kconfig | 9 +
drivers/net/can/Makefile | 1 +
drivers/net/can/bfin_can.c | 783 +++++++++++++++++++++++++
drivers/net/cnic.c | 11 +
drivers/net/cxgb3/cxgb3_main.c | 1 +
drivers/net/e1000e/defines.h | 2 +-
drivers/net/e1000e/es2lan.c | 97 ++-
drivers/net/e1000e/hw.h | 7 +
drivers/net/e1000e/ich8lan.c | 8 +-
drivers/net/e1000e/netdev.c | 2 +-
drivers/net/fec_mpc52xx.c | 121 ++--
drivers/net/gianfar.c | 1 +
drivers/net/ixgbe/ixgbe_82599.c | 1 +
drivers/net/ixgbe/ixgbe_ethtool.c | 1 +
drivers/net/ixgbe/ixgbe_main.c | 22 +-
drivers/net/ixgbe/ixgbe_type.h | 1 +
drivers/net/mv643xx_eth.c | 3 +
drivers/net/myri10ge/myri10ge.c | 4 +-
drivers/net/netxen/netxen_nic_init.c | 14 +-
drivers/net/netxen/netxen_nic_main.c | 49 ++-
drivers/net/sky2.c | 9 +
drivers/net/smc91x.c | 8 +-
drivers/net/wireless/ath/ath5k/eeprom.c | 3 +-
drivers/net/wireless/ath/ath5k/led.c | 2 +
drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
drivers/net/wireless/b43/main.c | 5 +-
drivers/net/wireless/iwlwifi/iwl-tx.c | 2 +-
drivers/net/wireless/mwl8k.c | 327 +++++------
drivers/net/wireless/orinoco/hermes_dld.c | 2 +-
drivers/net/wireless/rtl818x/rtl8187.h | 6 +
drivers/net/wireless/rtl818x/rtl8187_dev.c | 12 +-
drivers/net/wireless/rtl818x/rtl8187_leds.c | 68 ++-
drivers/net/wireless/rtl818x/rtl8187_leds.h | 2 +
drivers/net/wireless/rtl818x/rtl8187_rfkill.c | 4 +-
drivers/net/wireless/wl12xx/wl1251_main.c | 36 +-
include/linux/gigaset_dev.h | 22 +-
include/linux/if_ether.h | 2 -
include/net/compat.h | 2 +-
include/net/inet6_hashtables.h | 2 +-
include/net/inet_hashtables.h | 8 +-
include/net/inet_timewait_sock.h | 3 +
include/net/tcp.h | 23 -
net/atm/br2684.c | 11 +-
net/atm/lec.c | 10 +-
net/compat.c | 11 +-
net/core/dev.c | 10 +-
net/dccp/ipv4.c | 2 +-
net/dccp/ipv6.c | 4 +-
net/ipv4/inet_hashtables.c | 24 +-
net/ipv4/inet_timewait_sock.c | 61 ++-
net/ipv4/tcp.c | 5 -
net/ipv4/tcp_input.c | 35 +-
net/ipv4/tcp_ipv4.c | 2 +-
net/ipv4/tcp_timer.c | 29 +
net/ipv6/inet6_hashtables.c | 8 +-
net/ipv6/tcp_ipv6.c | 4 +-
net/key/af_key.c | 1 +
net/mac80211/cfg.c | 3 +-
net/mac80211/ieee80211_i.h | 1 +
net/mac80211/mesh.c | 2 +-
net/mac80211/mesh.h | 5 +-
net/mac80211/mesh_hwmp.c | 2 +-
net/mac80211/mlme.c | 10 +-
net/mac80211/rx.c | 1 -
net/mac80211/scan.c | 20 +-
net/mac80211/util.c | 2 +-
net/rfkill/core.c | 4 +-
net/wireless/reg.c | 75 +--
net/wireless/wext-compat.c | 1 +
77 files changed, 1677 insertions(+), 594 deletions(-)
create mode 100644 drivers/net/can/bfin_can.c
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
William Allen Simpson
2009-12-12 10:10:32 UTC
Permalink
Post by David Miller
Merge branch 'master' of git://git.kernel.org/.../linville/wireless-next-2.6
tcp: Remove runtime check that can never be true.
This is a poor patch that was never sent to the netdev list for review. Copies to
and from user space should always check for buffer overruns. A better patch was
submitted (attached) some time ago.

Miller's patch has 2 flaws:

1) It accidentally removed a comment line that describes the purpose of the
following memcpy(), paralleling language in the internet-draft.

2) It fails to test for buffer overruns. The existing code has an accurate test,
that compiles (to no code) correctly with current gcc. But it produces a warning
in some (fairly old) gcc versions.

Instead, the better patch uses the Kernel defined BUILD_BUG_ON(). Please
substitute the better patch in the main tree.
Post by David Miller
Merge branch 'master' of git://git.kernel.org/.../linville/wireless-2.6
Merge branch 'master' of /home/davem/src/GIT/linux-2.6/
Andrew Morton
2009-12-12 10:24:39 UTC
Permalink
Post by William Allen Simpson
Post by David Miller
Merge branch 'master' of git://git.kernel.org/.../linville/wireless-next-2.6
tcp: Remove runtime check that can never be true.
This is a poor patch that was never sent to the netdev list for review.
It's better than the original code, which was checking to see whether a
u8 exceeded 536!
Post by William Allen Simpson
Please substitute the better patch in the main tree.
Linus won't remove a commit from the middle of David's merge and
replace it with some unchangelogged, un-signed-off alternative.

An appropriate way to handle this is to prepare a new patch against
Linus or David's tree after this merge has been performed. Package
that patch in the usual way and send it to the usual recipients. That's
the no-fuss, no-drama, stuff-gets-done path.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
William Allen Simpson
2009-12-13 19:00:43 UTC
Permalink
Post by Andrew Morton
Post by William Allen Simpson
Post by David Miller
Merge branch 'master' of git://git.kernel.org/.../linville/wireless-next-2.6
tcp: Remove runtime check that can never be true.
This is a poor patch that was never sent to the netdev list for review.
It's better than the original code, which was checking to see whether a
u8 exceeded 536!
It's preventative, to insure against changes to field sizes. And it's
correct C in form that has compiled without error for a dozen years. But
as you pointed out, gcc 4.0 generates a warning, while gcc 4.4 doesn't....

In the olden days, we'd have done these tests with preprocessor code, and
that's apparently the style that Linux still prefers. Sorry, I've not paid
much attention since early debian, so I'm not up on the current state of
undocumented Linux defines.

As I mentioned in an early post to the netdev list, while I've long had
credit in BSD-derived systems, this is the first I've tried to implement for
Linux kernel -- although I did give permission 15 or so years ago for a fair
amount of my stuff to be ported here under GPL....

Thanks in advance for your patience.
Post by Andrew Morton
Post by William Allen Simpson
Please substitute the better patch in the main tree.
Linus won't remove a commit from the middle of David's merge and
replace it with some unchangelogged, un-signed-off alternative.
Actually, it *was* change-logged, discussed, and signed-off:

http://www.spinics.net/lists/netdev/msg115570.html

David rejected it with the deeply explanatory message:

"Guess again."

http://www.spinics.net/lists/netdev/msg115585.html

I'll also remind you that David has previously rejected range-checking in
other patches of mine, with the message:

"You're being way too anal here, and adding these checks to
drivers would be just a lot of rediculious bloat." [sic]

So, we have a fundamental difference about checking for negative before
stuffing a signed value into an unsigned value.

Then again, in 30+ years, AFAIK I've never shipped code that had a
serious denial of service attack because of a failure to range check.
Yes, I'm referring to 2.6.29, .30, and .31.

I may not be perfect, but I try really, really hard to get it right.
Post by Andrew Morton
An appropriate way to handle this is to prepare a new patch against
Linus or David's tree after this merge has been performed. Package
that patch in the usual way and send it to the usual recipients. That's
the no-fuss, no-drama, stuff-gets-done path.
It was ready before the merge was performed -- instead we got Miller-lite
drama, fuss, and no-stuff-gets-done....

Since David has rejected it, I was using this message to appeal.

Is there no ability to appeal poor decisions by a maintainer?
Eric Dumazet
2009-12-12 10:49:12 UTC
Permalink
Post by David Miller
Merge branch 'master' of
git://git.kernel.org/.../linville/wireless-next-2.6
tcp: Remove runtime check that can never be true.
=20
This is a poor patch that was never sent to the netdev list for revie=
w.=20
Copies to
and from user space should always check for buffer overruns. A bette=
r
patch was
submitted (attached) some time ago.
=20
=20
1) It accidentally removed a comment line that describes the purpose=
of
the
following memcpy(), paralleling language in the internet-draft.
=20
2) It fails to test for buffer overruns. The existing code has an accurate test,
that compiles (to no code) correctly with current gcc. But it produc=
es
a warning
in some (fairly old) gcc versions.
=20
Instead, the better patch uses the Kernel defined BUILD_BUG_ON(). Pl=
ease
substitute the better patch in the main tree.
=20
=20
Post by David Miller
Merge branch 'master' of
git://git.kernel.org/.../linville/wireless-2.6
Merge branch 'master' of /home/davem/src/GIT/linux-2.6/
William, as I already said, you wont solve your problem with David
alerting whole earth, Linus, God, whoever, because we dont care,
we have our own problems.

This drama is really ridiculous, could we go forward, correct bugs,
add documentation, and so on ?

If you really want this BUILD_BUG_ON() (because some dev could
introduce a bug changing TCP_COOKIE_PAIR_SIZE or TCP_MSS_DEFAULT (???)
in the future, without David or other network dev noticing this),
please submit a _normal_ patch against net-2.6 and through David Miller=
,
the official network maintainer, your best friend for network patches.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Arnaldo Carvalho de Melo
2009-12-12 19:42:22 UTC
Permalink
Post by Eric Dumazet
Post by David Miller
Merge branch 'master' of
This is a poor patch that was never sent to the netdev list for rev=
iew.=20
Post by Eric Dumazet
=20
William, as I already said, you wont solve your problem with David
alerting whole earth, Linus, God, whoever, because we dont care,
we have our own problems.
=20
This drama is really ridiculous, could we go forward, correct bugs,
add documentation, and so on ?
Indeed, this is over the top, either try to get along with people that
proved their worth thru almost decades of hard work, even being difficu=
lt
to deal with when treated unreasonably (and sometimes when in a bad moo=
d
;-)) or get the highway and never look back!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller
2009-12-12 11:29:38 UTC
Permalink
I'm doing a quick push to fix the Kaweth USB driver build
failure. It's due to a miscommunication between Greg KH
and myself, and we'll make sure this doesn't happen again.

There's also two Intel gigabit fixes from Alexander Duyck and
a be2net driver fix from Ajit Khaparde.

Please pull, thanks a lot!

The following changes since commit 053fe57ac249a9531c396175778160d9e9509399:
Linus Torvalds (1):
Merge git://git.kernel.org/.../davem/net-2.6

are available in the git repository at:

master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git master

Ajit Khaparde (1):
be2net: fix error in rx completion processing.

Alexander Duyck (2):
igb: fix handling of mailbox collisions between PF/VF
igbvf: avoid reset storms due to mailbox issues

Oliver Neukum (1):
usb: remove rare pm primitive for conversion to new API

drivers/net/benet/be_main.c | 4 ++--
drivers/net/igb/igb_main.c | 22 +++++++++++++---------
drivers/net/igbvf/igbvf.h | 1 +
drivers/net/igbvf/netdev.c | 8 +++++++-
drivers/net/usb/kaweth.c | 4 ++--
5 files changed, 25 insertions(+), 14 deletions(-)
andrew hendry
2009-12-14 04:17:19 UTC
Permalink
David Miller
2009-12-14 04:20:37 UTC
Permalink
From: andrew hendry <***@gmail.com>
Date: Mon, 14 Dec 2009 15:17:19 +1100
Hi Dave,
There were some other X.25 patches you took into net-next last month.
X25: Fix oops and refcnt problems from x25_dev_get
X25: Check for errors in x25_init
X25: Move SYSCTL ifdefs into header
But they didn't make it into the pull. If they need some work please
let me know.
I'm waiting for Ralf, the maintainer, to review your changes.
andrew hendry
2009-12-14 04:26:18 UTC
Permalink
Thanks, I didn't know X.25 was actively maintained. I get bounces.
Is the the maintainers out of date?

AX.25 NETWORK LAYER
M: Ralf Baechle <***@linux-mips.org>

X.25 NETWORK LAYER
Post by David Miller
Date: Mon, 14 Dec 2009 15:17:19 +1100
Hi Dave,
There were some other X.25 patches you took into net-next last month.
X25: Fix oops and refcnt problems from x25_dev_get
X25: Check for errors in x25_init
X25: Move SYSCTL ifdefs into header
But they didn't make it into the pull. If they need some work please
let me know.
I'm waiting for Ralf, the maintainer, to review your changes.
David Miller
2009-12-14 04:35:00 UTC
Permalink
From: andrew hendry <***@gmail.com>
Date: Mon, 14 Dec 2009 15:26:18 +1100
Post by andrew hendry
Thanks, I didn't know X.25 was actively maintained. I get bounces.
Is the the maintainers out of date?
AX.25 NETWORK LAYER
X.25 NETWORK LAYER
Sorry, I confused the two.

Please resubmit your fixes, if nobody is responding I
guess I have to handle them directly.
Arnd Bergmann
2009-12-14 11:53:41 UTC
Permalink
Post by andrew hendry
Thanks, I didn't know X.25 was actively maintained. I get bounces.
Is the the maintainers out of date?
From looking at the posts on the x.25 mailing list and the changes
that went into the kernel during the last three years in that area,
I think it is safe to say that you are now the maintainer ;-).

The last mail on this topic from Henner Eisen was around 2001.
Post by andrew hendry
AX.25 NETWORK LAYER
X.25 NETWORK LAYER
How about this change?

--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5839,9 +5839,9 @@ F: sound/soc/codecs/wm8350.c
F: sound/soc/codecs/wm8400.c

X.25 NETWORK LAYER
-M: Henner Eisen <***@baty.hanse.de>
+M: Andrew Hendry <***@gmail.com>
L: linux-***@vger.kernel.org
-S: Maintained
+S: Odd Fixes
F: Documentation/networking/x25*
F: include/net/x25*
F: net/x25/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
andrew hendry
2009-12-14 22:07:23 UTC
Permalink
That works for me. I have access to some X.25 networks for testing and
keep an eye on the mailing lists.
Post by andrew hendry
Post by andrew hendry
Thanks, I didn't know X.25 was actively maintained. I get bounces.
Is the the maintainers out of date?
From looking at the posts on the x.25 mailing list and the changes
that went into the kernel during the last three years in that area,
I think it is safe to say that you are now the maintainer ;-).
The last mail on this topic from Henner Eisen was around 2001.
Post by andrew hendry
AX.25 NETWORK LAYER
X.25 NETWORK LAYER
How about this change?
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5839,9 +5839,9 @@ F: =A0 =A0 =A0 =A0sound/soc/codecs/wm8350.c
=A0F: =A0 =A0 sound/soc/codecs/wm8400.c
=A0X.25 NETWORK LAYER
-S: =A0 =A0 Maintained
+S: =A0 =A0 Odd Fixes
=A0F: =A0 =A0 Documentation/networking/x25*
=A0F: =A0 =A0 include/net/x25*
=A0F: =A0 =A0 net/x25/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller
2009-12-15 05:51:04 UTC
Permalink
From: andrew hendry <***@gmail.com>
Date: Tue, 15 Dec 2009 09:07:23 +1100
Post by andrew hendry
That works for me. I have access to some X.25 networks for testing and
keep an eye on the mailing lists.
Applied.
David Miller
2009-12-16 08:03:02 UTC
Permalink
Revert a set of TCP changes which were not fully cooked.
The kernel log message signature for this regression is:

Badness at net/ipv4/inet_connection_sock.c:293

Julia Lawall found and fixed several instances of sizeof(pointer) that
were definitely not intended.

Dynamic sizing of the UDP hash table introduced a subtle bug, fixed
by Eric Dumazet.

A couple netfilter bug fixes via Patrick McHardy, including a nasty
one involving a conflict between the defragmentation done by
the core stack and those done by various parts of netfilter.

Update x25 maintainer.

And a few small driver bug fixes to round things out.

Please pull, thanks a lot.

The following changes since commit 3ea6b3d0e6d0ffd91c0f8cadeb69b7133c038b32:
Linus Torvalds (1):
Merge branch 'for_linus' of git://git.kernel.org/.../jack/linux-udf-2.6

are available in the git repository at:

master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git master

Arnd Bergmann (1):
x25: Update maintainer.

David S. Miller (2):
tcp: Revert per-route SACK/DSACK/TIMESTAMP changes.
Merge branch 'master' of git://git.kernel.org/.../kaber/nf-2.6

Eric Dumazet (2):
udp: udp_lib_get_port() fix
packet: dont call sleeping functions while holding rcu_read_lock()

Eric W. Biederman (1):
net: Fix userspace RTM_NEWLINK notifications.

Florian Fainelli (1):
bcm63xx_enet: fix compilation failure after get_stats_count removal

Geert Uytterhoeven (1):
can: CAN_MCP251X should depend on HAS_DMA

Gurucharan Shetty (1):
ixgbe: allow tx of pre-formatted vlan tagged packets

Jan Engelhardt (1):
netfilter: xtables: document minimal required version

Joe Perches (1):
drivers/net/bonding/: : use pr_fmt

Julia Lawall (4):
drivers/atm: Correct code taking the size of a pointer
drivers/net/sfc: Correct code taking the size of a pointer
drivers/net/cpmac.c: Correct code taking the size of a pointer
drivers/net/usb: Correct code taking the size of a pointer

Ken Kawasaki (1):
3c574_cs: disable irq before calling el3_interrupt

Magnus Damm (1):
net: sh_eth alignment fix for sh7724 using NET_IP_ALIGN V2

Mallikarjuna R Chilakala (2):
ixgbe: Fix tx_restart_queue/non_eop_desc statistics counters
ixgbe: Fix 82598 premature copper PHY link indicatation

Oliver Hartkopp (1):
can: Fix data length code handling in rx path

Patrick McHardy (2):
ipv6: reassembly: use seperate reassembly queues for conntrack and local delivery
netfilter: fix crashes in bridge netfilter caused by fragment jumps

Simon Horman (1):
ipvs: zero usvc and udest

Xiaotian Feng (1):
ipvs: fix synchronization on connection close

roel kluin (1):
mlx4_core: return a negative error value

stephen hemminger (2):
sky2: print Optima chip name
sky2: leave PCI config space writeable

Documentation/Changes | 2 +
MAINTAINERS | 4 +-
drivers/atm/iphase.c | 2 +-
drivers/net/bcm63xx_enet.c | 12 +-
drivers/net/bonding/bond_3ad.c | 171 ++++---
drivers/net/bonding/bond_alb.c | 38 +-
drivers/net/bonding/bond_ipv6.c | 12 +-
drivers/net/bonding/bond_main.c | 607 +++++++++---------------
drivers/net/bonding/bond_sysfs.c | 327 +++++--------
drivers/net/can/Kconfig | 2 +-
drivers/net/can/at91_can.c | 2 +-
drivers/net/can/bfin_can.c | 2 +-
drivers/net/can/mcp251x.c | 13 +-
drivers/net/can/mscan/mscan.c | 3 +-
drivers/net/can/sja1000/sja1000.c | 18 +-
drivers/net/can/ti_hecc.c | 2 +-
drivers/net/can/usb/ems_usb.c | 2 +-
drivers/net/cpmac.c | 2 +-
drivers/net/ixgbe/ixgbe_82598.c | 38 ++
drivers/net/ixgbe/ixgbe_main.c | 20 +-
drivers/net/ixgbe/ixgbe_type.h | 2 +
drivers/net/mlx4/sense.c | 2 +-
drivers/net/pcmcia/3c574_cs.c | 4 +
drivers/net/pcmcia/3c589_cs.c | 4 +
drivers/net/sfc/selftest.c | 2 +-
drivers/net/sh_eth.c | 7 +-
drivers/net/sky2.c | 15 +-
drivers/net/usb/rtl8150.c | 2 +-
include/linux/can/dev.h | 9 +
include/linux/rtnetlink.h | 6 +-
include/net/dst.h | 2 +-
include/net/ip.h | 1 +
include/net/ipv6.h | 8 +
include/net/netfilter/ipv6/nf_conntrack_ipv6.h | 2 +-
include/net/tcp.h | 3 +-
net/core/dev.c | 11 +
net/core/rtnetlink.c | 6 +-
net/ipv4/netfilter/nf_defrag_ipv4.c | 21 +-
net/ipv4/syncookies.c | 27 +-
net/ipv4/tcp_input.c | 24 +-
net/ipv4/tcp_ipv4.c | 21 +-
net/ipv4/tcp_minisocks.c | 10 +-
net/ipv4/tcp_output.c | 18 +-
net/ipv4/udp.c | 7 +-
net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c | 19 +-
net/ipv6/netfilter/nf_conntrack_reasm.c | 7 +-
net/ipv6/reassembly.c | 5 +-
net/ipv6/syncookies.c | 28 +-
net/ipv6/tcp_ipv6.c | 3 +-
net/netfilter/ipvs/ip_vs_core.c | 1 +
net/netfilter/ipvs/ip_vs_ctl.c | 4 +
net/packet/af_packet.c | 71 ++--
52 files changed, 745 insertions(+), 886 deletions(-)
David Miller
2009-12-21 03:43:35 UTC
Permalink
Here are the bug fixes which have accumulated over the past
week or so.

1) gc_min_interval_ms ipv6 sysctl doesn't update per-namespace
properly, fix from Alexey Dobriyan.

2) Bluetooth bug fixes from Gustavo F. Padovan, Oliver Neukum,
Roel Kluin, and Andrei Emeltchenko.

3) Fix e1000e LED settings on 82571 and 82572 chips, fix from
Bruce Allan.

4) bnx2 crash in reset_task fix from Breno Leitao.

5) TI DaVinci EMAC MDIO bus frequence programming fix from
Nageswari Srinivasan.

6) e100 regression fix from Roger Oksanen. When we moved this
driver over to pci pools, we added a subtle bug because
pci pool objects, unlike pci_alloc_consistent() allocations,
do not get bzero()'d out for the caller.

7) gianfar fixes from Sandeep Gopalpet.

8) netxen sysfs fix from Stephen Hemminger

9) mISDN needs to use DECLARE_COMPLETION_ONSTACK, fix from Yong Zhang

Please pull, thanks a lot!

The following changes since commit dd59f6c76b265ed2ff18b497d6105a9511b1=
feb1:
Linus Torvalds (1):
Merge branch 'for-linus' of git://git.kernel.org/.../mattst88/a=
lpha-2.6

are available in the git repository at:

master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git master

Alexey Dobriyan (1):
netns: fix net.ipv6.route.gc_min_interval_ms in netns

Andrei Emeltchenko (1):
Bluetooth: Fix L2CAP locking scheme regression

Breno Leitao (2):
bnx2: reset_task is crashing the kernel. Fixing it.
bnx2: fixing a timout error due not refreshing TX timers correctl=
y

Bruce Allan (1):
e1000e: LED settings in EEPROM ignored on 82571 and 82572

Gustavo F. Padovan (2):
Bluetooth: Fix unset of RemoteBusy flag for L2CAP
Bluetooth: Ack L2CAP I-frames before retransmit missing packet

Michael Chan (1):
bnx2: Fix bnx2_netif_stop() merge error.

Nageswari Srinivasan (1):
TI DaVinci EMAC: Fix MDIO bus frequency configuration

Oliver Neukum (1):
Bluetooth: Prevent ill-timed autosuspend in USB driver

Roel Kluin (2):
Bluetooth: Fix PTR_ERR return of wrong pointer in hidp_setup_hid(=
)
broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_=
rxrefclk()

Roger Oksanen (1):
e100: Fix broken cbs accounting due to missing memset.

Sandeep Gopalpet (3):
gianfar: Fix a filer bug
gianfar: Fix stats support
gianfar: Fix bit definitions of IMASK_GRSC and IMASK_GTSC

Stephen Hemminger (1):
netxen: use module parameter correctly

Uwe Kleine-K=F6nig (1):
can/at91: don't check platform_get_irq's return value against zer=
o

Yang Hongyang (1):
ipv6: fix an oops when force unload ipv6 module

Yong Zhang (1):
mISDN: use DECLARE_COMPLETION_ONSTACK for non-constant completion

drivers/bluetooth/btusb.c | 1 +
drivers/isdn/mISDN/l1oip_core.c | 2 +-
drivers/net/bnx2.c | 12 ++++++-
drivers/net/can/at91_can.c | 2 +-
drivers/net/davinci_emac.c | 2 +-
drivers/net/e100.c | 2 +-
drivers/net/e1000e/82571.c | 6 ---
drivers/net/gianfar.c | 50 +++++++++++++++++++++++++-=
---
drivers/net/gianfar.h | 18 +++++++++-
drivers/net/netxen/netxen_nic_main.c | 57 ++------------------------=
--------
drivers/net/phy/broadcom.c | 3 +-
net/bluetooth/hidp/core.c | 2 +-
net/bluetooth/l2cap.c | 5 ++-
net/ipv6/reassembly.c | 3 +-
net/ipv6/route.c | 1 +
15 files changed, 86 insertions(+), 80 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Continue reading on narkive:
Loading...