[PATCH 3.4-stable v2] ipv6: reallocate addrconf router for ipv6 address when lo device up

[chenweilong]

It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951

The patch can't be applied directly, as it' used the function introduced
by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
either.

====================

From: Gao feng <***@cn.fujitsu.com>

commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.

This commit don't have a stable tag, but it fix the bug
no reply after loopback down-up.It's very worthy to be
applied to stable 3.4 kernels.

The bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951


CC: Sabrina Dubroca <***@queasysnail.net>
CC: Hannes Frederic Sowa <***@stressinduktion.org>
Reported-by: Weilong Chen <***@huawei.com>
Signed-off-by: Weilong Chen <***@huawei.com>
Signed-off-by: Gao feng <***@cn.fujitsu.com>
Acked-by: Hannes Frederic Sowa <***@stressinduktion.org>
Signed-off-by: David S. Miller <***@davemloft.net>
[weilong: s/ip6_rt_put/dst_release]
Signed-off-by: Chen Weilong <***@huawei.com>
---
net/ipv6/addrconf.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index abfa007..25399bf 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2435,8 +2435,18 @@ static void init_loopback(struct net_device *dev)
if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
continue;

- if (sp_ifa->rt)
- continue;
+ if (sp_ifa->rt) {
+ /* This dst has been added to garbage list when
+ * lo device down, release this obsolete dst and
+ * reallocate a new router for ifa.
+ */
+ if (sp_ifa->rt->dst.obsolete > 0) {
+ dst_release(&sp_ifa->rt->dst);
+ sp_ifa->rt = NULL;
+ } else {
+ continue;
+ }
+ }

sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);

-- 1.7.12

[Luis Henriques]

Post by chenweilong
It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=3D67951
=20
The patch can't be applied directly, as it' used the function introdu=

ced

Post by chenweilong
by "commit 94e187c0" ip6_rt_put(), that patch can't be applied direct=

ly

Post by chenweilong
either.

I'm queuing this commit for the 3.11 kernel as well. Thanks!

Cheers,
--
Lu=EDs

Post by chenweilong
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=20
=20
commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.
=20
This commit don't have a stable tag, but it fix the bug
no reply after loopback down-up.It's very worthy to be
applied to stable 3.4 kernels.
=20
The bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=3D67951
=20
=20
[weilong: s/ip6_rt_put/dst_release]
---
net/ipv6/addrconf.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
=20
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index abfa007..25399bf 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2435,8 +2435,18 @@ static void init_loopback(struct net_device *d=

ev)

Post by chenweilong
if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
continue;
=20
- if (sp_ifa->rt)
- continue;
+ if (sp_ifa->rt) {
+ /* This dst has been added to garbage list when
+ * lo device down, release this obsolete dst and
+ * reallocate a new router for ifa.
+ */
+ if (sp_ifa->rt->dst.obsolete > 0) {
+ dst_release(&sp_ifa->rt->dst);
+ sp_ifa->rt =3D NULL;
+ } else {
+ continue;
+ }
+ }
=20
sp_rt =3D addrconf_dst_alloc(idev, &sp_ifa->addr, 0);
=20
-- 1.7.12
=20
--
To unsubscribe from this list: send the line "unsubscribe stable" in
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Greg Kroah-Hartman]

Post by chenweilong
It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
The patch can't be applied directly, as it' used the function introduced
by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
either.

Much better, thanks for the fixed patch.

greg k-h

[Ben Hutchings]

Post by chenweilong
It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
The patch can't be applied directly, as it' used the function introduced
by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
either.
====================
commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.
This commit don't have a stable tag, but it fix the bug
no reply after loopback down-up.It's very worthy to be
applied to stable 3.4 kernels.
The bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951

[...]

It looks like this is needed for 3.2.y as well, so I've queued it up.
Thanks.

Ben.